Base box #4
Open
Base box #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed the generator that gets installed from webapp and angular to mcfly-ng2, exposed port 3000 instead of 9000, and also added gulp and bower to installed tools Signed-off-by: Ajay Ganapathy <[email protected]>
now, files from the host system will show up in the docker container's /home/yeoman Signed-off-by: Ajay Ganapathy <[email protected]>
gave non-root user "yeoman" the correct BASH shell and set permissions on the work directory. Signed-off-by: Ajay Ganapathy <[email protected]>
generator-mcfly-ng2 uses port 5000 to serve the web app, not port 3000 Signed-off-by: Ajay Ganapathy <[email protected]>
/usr directory now has RWX permissions for all users. This isn't a very secure solution, but it's a stopgap for now. Yeoman user can now run npm and install packages to /usr Signed-off-by: Ajay Ganapathy <[email protected]>
generator-mcfly-ng2 does NOT use gulp. It uses webpack, so I removed gulp from the dockerfile Signed-off-by: Ajay Ganapathy <[email protected]>
browsersync UI runs on port 3001, so I exposed the port to make it easy to configure it while it's running
installed generator-gulp-angular, gulp, and bower. Then, exposed ports 3000 and 3001 for browsersync
/usr is no longer accessible by any user. Instead, npm now installs global packages to the yeoman user's home directory
un-exposed port 9000, and exposed ports 3000 and 3001 since that's where the generator set up browsersync to serve
the README for this generator now includes all of the instructions you will need to set up this docker box.
# Conflicts: # Dockerfile
The README for the base box now includes helpful gifs and detailed instructions on how to set up the docker container Signed-off-by: Ajay Ganapathy <[email protected]>
I merged the generator-gulp-angular code into master, which I then merged into base-box, just for consistency. I removed the parts that were specific to the generator-gulp-angular docker container to leave you with the base-box code. Signed-off-by: Ajay Ganapathy <[email protected]>
the readme was missing instructions for mapping the ports on the docker container to the host, so I added those instructions in, and included a helpful .gif Signed-off-by: Ajay Ganapathy <[email protected]>
Source image ubuntu:latest failed upon building, so I changed the image to ubuntu:trusty. ubuntu:trusty is officially supported by node js Signed-off-by: Ajay Ganapathy <[email protected]>
Signed-off-by: Ajay Ganapathy <[email protected]> Conflicts: README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the NPM prefix to within the yeoman user's home directory, and also re-wrote the readme. This base-box does not contain any pre-installed generators